Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#228 - Basic Hello World Slack Command Bot #236

Merged
merged 9 commits into from
Nov 24, 2023
Merged

#228 - Basic Hello World Slack Command Bot #236

merged 9 commits into from
Nov 24, 2023

Conversation

ManasMadan
Copy link
Contributor

What does this PR do?

This PR Closes the issue #228 by implementing a Slack Command Bot Template in Node.js

Test Plan

  • I have not changed any code but have written the code in node/slack-command-bot directory.
  • I have tested the code on Appwrite Cloud by creating a function and a Slack Command on Slack.
    Demo Video Link
  • I have made sure the API Verify the Request according to Slack Documentation

Related PRs and Issues

This PR is related to issue #228 and merging this PR closes that issue

Have you read the Contributing Guidelines on issues?

Yes I Have read the contributing guidelines

@ManasMadan
Copy link
Contributor Author

@Haimantika Merging this PR closes issue #228

@ManasMadan ManasMadan mentioned this pull request Oct 14, 2023
Closed
6 tasks
@ManasMadan
Copy link
Contributor Author

@Haimantika any updates ?

@Haimantika
Copy link

@Haimantika any updates ?

I have assigned my team mate. You can also join us for PR reviews tomorrow on Discord and get it reviewed live.

@ManasMadan
Copy link
Contributor Author

@loks0n Any Updates ?

Meldiron
Meldiron requested changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very solid PR ✨ I left some comments to ensure we follow our typical approach to templates. Please address and Ill give it another look

node/slack-command-bot/README.md Outdated Show resolved Hide resolved
node/slack-command-bot/README.md Outdated Show resolved Hide resolved
node/slack-command-bot/src/main.js Outdated Show resolved Hide resolved
node/slack-command-bot/src/main.js Outdated Show resolved Hide resolved
node/slack-command-bot/package.json Outdated Show resolved Hide resolved
node/slack-command-bot/src/main.js Outdated Show resolved Hide resolved
node/slack-command-bot/README.md Outdated Show resolved Hide resolved
node/slack-command-bot/src/main.js Outdated Show resolved Hide resolved
node/slack-command-bot/src/main.js Outdated Show resolved Hide resolved
node/slack-command-bot/src/main.js Outdated Show resolved Hide resolved
@ManasMadan
Copy link
Contributor Author

@Meldiron I will do the changes and let you know.
Thanks !

@ManasMadan
Copy link
Contributor Author

@Meldiron @loks0n I have did all the changes and have tested them Please check
Thanks !

loks0n
loks0n requested changes Oct 23, 2023
View reviewed changes
node/slack-command-bot/src/main.js Outdated Show resolved Hide resolved
node/slack-command-bot/src/main.js Outdated Show resolved Hide resolved
node/slack-command-bot/src/utils.js Outdated Show resolved Hide resolved
node/slack-command-bot/src/main.js Outdated Show resolved Hide resolved
node/slack-command-bot/src/utils.js Outdated Show resolved Hide resolved
node/slack-command-bot/src/utils.js Outdated Show resolved Hide resolved
node/slack-command-bot/README.md Outdated Show resolved Hide resolved
node/slack-command-bot/README.md Outdated Show resolved Hide resolved
@ManasMadan
Copy link
Contributor Author

@loks0n Have done the changes
Thanks !

loks0n
loks0n requested changes Oct 24, 2023
View reviewed changes
node/slack-command-bot/src/utils.js Outdated Show resolved Hide resolved
node/slack-command-bot/src/utils.js Outdated Show resolved Hide resolved
node/slack-command-bot/src/utils.js Outdated Show resolved Hide resolved
node/slack-command-bot/src/utils.js Outdated Show resolved Hide resolved
node/slack-command-bot/src/utils.js Outdated Show resolved Hide resolved
node/slack-command-bot/src/utils.js Outdated Show resolved Hide resolved
node/slack-command-bot/src/utils.js Outdated Show resolved Hide resolved
@loks0n loks0n requested a review from Meldiron October 24, 2023 14:50
@ManasMadan
Copy link
Contributor Author

ManasMadan commented Oct 24, 2023 •
edited
Loading

@loks0n @Meldiron Please check now have done the changes
Thanks !

@ManasMadan
Copy link
Contributor Author

@loks0n @Meldiron any updates ?

loks0n
loks0n requested changes Oct 26, 2023
View reviewed changes
Copy link
Member

@loks0n loks0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, a few final things

node/slack-command-bot/src/utils.js Outdated Show resolved Hide resolved
node/slack-command-bot/src/utils.js Outdated Show resolved Hide resolved
@ManasMadan
Copy link
Contributor Author

@loks0n have done the changes
Please Check
Thanks !

loks0n
loks0n approved these changes Oct 27, 2023
View reviewed changes
node/slack-command-bot/src/utils.js Outdated Show resolved Hide resolved
node/slack-command-bot/src/utils.js Show resolved Hide resolved
@github-actions github-actions bot mentioned this pull request Nov 1, 2023
Closed
@tessamero tessamero linked an issue Nov 2, 2023 that may be closed by this pull request
🚀 Feature: Add Slack command bot templates #228
Closed
6 tasks
@ManasMadan
Copy link
Contributor Author

@Haimantika Am i Eligible for Appwrite Swags ?
If Yes do i need to do something to get them

@ManasMadan
Copy link
Contributor Author

@Meldiron @loks0n can you please merge this

@ManasMadan
Copy link
Contributor Author

@Haimantika Am i Eligible for Appwrite Swags ? If Yes do i need to do something to get them

@Haimantika

@loks0n
Copy link
Member

loks0n commented Nov 7, 2023

@Haimantika Am i Eligible for Appwrite Swags ? If Yes do i need to do something to get them

Don't worry - you are eligible for the swags 🥳

We will merge the PR when Meldiron is able to review.

@tessamero
Copy link

@ManasMadan add your discord handle here so we can contact you about swags after the PR is merged soon :)

@ManasMadan
Copy link
Contributor Author

@tessamero My discord username is manasmadan

@loks0n loks0n merged commit 611ec65 into appwrite:main Nov 24, 2023
@github-actions github-actions bot mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loks0n loks0n loks0n approved these changes

@Meldiron Meldiron Meldiron approved these changes

Assignees

@ManasMadan ManasMadan

Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add Slack command bot templates
5 participants
@ManasMadan @Haimantika @loks0n @tessamero @Meldiron